Hi @alex40724 ,

I completed the review of the Modules/Glossary component.

Results:

• The code style is PSR-2 + X compliant
• No usage of $_GET / $_POST / $_REQUEST / $_SESSION
• There is a Unit Test Suite with at least one unit test
• The unit tests pass
• External libraries are compatible with PHP 8 (if relevant)
• There are no serious PhpStorm Code Inspection issues left
• The types are fully documented (PhpDoc) or explict PHP types are used (type hints, return types, typed properties)

I also fixed some trivial inspection profile issues.

The following methods MUST be checked:

• \ilObjGlossary::create: An untyped boolean parameter is defined, the parent method has no parameter at all

Further actions needed:

• https://github.com/ILIAS-eLearning/ILIAS/pull/4136/files#diff-a107664a8591045a3d243fe5faa6419206f6b54b9e3b4763c5f63abb4d049b52R58
• https://github.com/ILIAS-eLearning/ILIAS/pull/4136/files#diff-5ee56c0535b02d8a1c90d9397b822801423121f9926c60774438f916742116b2R84
• https://github.com/ILIAS-eLearning/ILIAS/pull/4136/files#diff-a107664a8591045a3d243fe5faa6419206f6b54b9e3b4763c5f63abb4d049b52R58

Type documention or explict types are missing for the following methods:

• \ilObjGlossary::getAdvMDSubItemTitle / Reason: No types defined/documented in parent class (which has to be provided by another maintainer)

I suggest to specify the expected type of arrays (where possible) by using PHPDoc, e.g.:

• \ilObjGlossary::removeOfflineGlossaries: $a_glo_ids could be int[].
• \ilObjGlossaryAccess::_lookupOnlineStatus: $a_ids could be int[], the return type is array<int, bool>.
• ... some others ...

Best regards,
@mjansenDatabay